add writeBlockData method #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanubhadoria
added a commit
that referenced
this pull request
Dec 30, 2013
add writeBlockData method
|
Thanks for this addition. |
shantanubhadoria
added a commit
that referenced
this pull request
Dec 30, 2013
- spelling fixes [Shantanu Bhadoria] - Added more documentation, used mailmap to remove duplicates in contributors information, Thanks to git shortlog: https://www.kernel.org/pub/software/scm/git/docs/git-shortlog.html [Shantanu Bhadoria] - Merge pull request #2 from jonathanstowe/master add writeBlockData method [Shantanu Bhadoria] - add writeBlockData method [Jonathan Stowe]
|
:) On Sun, 2013-12-29 at 20:44 -0800, Shantanu Bhadoria wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for making Device::SMBus.
I have used it to make Device::PiGlow and it works great.
I noticed that you implemented the XS code for the block write but didn't expose it in the Perl API, this implements that.
I've actually implemented it directly in my code, and it works fine as implemented (for what I wanted to do.) So know rush to make a release :)
Because I don't have a device that I can read from I didn't implement the read block data :)